Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1164#discussion_r50282839
  
    --- Diff: 
brooklyn-server/rest/rest-server/src/main/java/org/apache/brooklyn/rest/resources/ServerResource.java
 ---
    @@ -218,6 +218,7 @@ public void run() {
                             if (shutdownHandler != null) {
                                 shutdownHandler.onShutdownRequest();
                             } else {
    +                            // should always be set as it is required by 
jersey injection?
    --- End diff --
    
    I think some tests could inject null value if the hook is of no interest to 
them. Certainly shouldn't get to this piece of code in this case.
    Probably safe to remove now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to