Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1162#discussion_r50286548
  
    --- Diff: 
brooklyn-server/core/src/main/java/org/apache/brooklyn/core/typereg/AbstractTypePlanTransformer.java
 ---
    @@ -103,7 +103,8 @@ public Object create(final RegisteredType type, final 
RegisteredTypeLoadingConte
                     @Override protected Object visitSpec() {
                         try { 
                             AbstractBrooklynObjectSpec<?, ?> result = 
createSpec(type, context);
    -                        result.catalogItemId(type.getId());
    +                        // see notes in CampResolver setting 
catalogItemId; we might need to keep both
    --- End diff --
    
    I do see any new notes in `CampResolver` - did you mean in 
`AbstractBrooklynObjectSpec`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to