Github user tbouron commented on the pull request:

    
https://github.com/apache/incubator-brooklyn/pull/1176#issuecomment-175512415
  
    LGTM.
    
    One comment though. This generate a JS file which encapsulates the JSON 
data into a JS var. While this is ok for the documentation as it imports the 
file directly, it's a bit tedious to share the info with other services (i.e. 
community catalog) as we will need to `eval` this file to get the data.
    I know it was not introduced by this PR but would it be better to get this 
opportunity to change the format from JS to JSON?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to