Github user ahgittin commented on the pull request:
https://github.com/apache/brooklyn-ui/pull/17#issuecomment-197866283
builds fine now, and works well as far as i've been able to test it. some
comments so far...
technical:
* most of the time autocomplete does not show, e.g. on minRam; is there a
way to make it more obvious?
cosmetic:
* capitalization is inconsistent. for titles/labels the pattern has been
"Location Name" (all words in initial caps, acronyms all caps) not "location
name" or "Location name"
* more help text is required; imagine a new user -- they won't know what to
put for "location id"; could say "Give a label to identify this location.
Typically this is lower case using hyphens and no spaces, such as
my-openstack-ireland" and similarly for "name" ("Optionally provide a display
name for this location, using capitals and spaces, such as 'My OpenStack
(Ireland)'."), and "identity" / "credential" it isn't clear this is to log on
to the cloud
* how will a user know what BYON is? (a circle icon giving popup help
could work for this and the previous, if too much text is not wanted;
alternatively we could call it "Manual IP Addresses")
* the message about "Required information about your location" is cryptic
and in fact wrong as many of the fields are not required; remove it altogether?
* the "additional configuration" page is imposing; can we make it clear
that there is no need to set anything, but if you want to put constraints or
special login there are many config keys available (possibly with link to the
website)
conceptual:
* I don't think `localhost` should be a top-level item. it's only
something advanced users should try. extending an existing location is
probably more important. we could call that tab "Advanced" and within it a
text field for `type` with autocomplete allowing `localhost` and any named
locations the user has previously set up.
a huge leap forward!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
