[ 
https://issues.apache.org/jira/browse/BROOKLYN-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15226706#comment-15226706
 ] 

ASF GitHub Bot commented on BROOKLYN-249:
-----------------------------------------

Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/103#discussion_r58579137
  
    --- Diff: 
core/src/test/java/org/apache/brooklyn/location/byon/ByonLocationResolverRebindTest.java
 ---
    @@ -0,0 +1,69 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.brooklyn.location.byon;
    +
    +import static org.testng.Assert.assertEquals;
    +import static org.testng.Assert.assertTrue;
    +
    +import org.apache.brooklyn.api.location.LocationSpec;
    +import org.apache.brooklyn.api.location.MachineLocation;
    +import org.apache.brooklyn.api.location.MachineProvisioningLocation;
    +import org.apache.brooklyn.core.mgmt.rebind.RebindTestFixtureWithApp;
    +import org.apache.brooklyn.location.ssh.SshMachineLocation;
    +import org.testng.annotations.Test;
    +
    +import com.google.common.collect.ImmutableMap;
    +
    +public class ByonLocationResolverRebindTest extends 
RebindTestFixtureWithApp {
    --- End diff --
    
    This should have been included in 
https://github.com/apache/brooklyn-server/pull/91, but was accidentally missed 
out!
    
    Not quite appropriate to include it in this commit, but no big deal in my 
opinion.


> errors using external config for JcloudsLocation
> ------------------------------------------------
>
>                 Key: BROOKLYN-249
>                 URL: https://issues.apache.org/jira/browse/BROOKLYN-249
>             Project: Brooklyn
>          Issue Type: Bug
>            Reporter: Aled Sage
>
> Using 0.10.0-SNAPSHOT (also affecting 0.9.0-rc2), I hit problems using 
> external config with JcloudsLocation.
> First it failed to resolve the external config for the ssh publicKeyData and 
> privateKeyData.
> After fixing that, it failed to rebind to my persisted state that included 
> the external config in the location (it tried to coerce the 
> {{DeferredSupplier}} to a String).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to