Hi Andrew, all,
This does *not* sound like a blocker to me.
To give some more background, the RebindManager.forcePersistNow method
fails if persistence is disabled.
The reason Andrew hit this is he is using the
`SoftLayerSameVlanLocationCustomizer` added in [1]. This calls
forcePersistNow, even if persistence is disabled. One can work around
the problem by only including `SoftLayerSameVlanLocationCustomizer` in
situations where persistence is enabled (which will be the case in all
production situations).
I suggest that we push ahead with rc4, and include Andrew's fix [2] in
master and the 0.9.x branch (for if we subsequently produce a 0.9.1).
Aled
[1] https://github.com/apache/brooklyn-server/pull/53
[2] https://github.com/apache/brooklyn-server/pull/113
On 12/04/2016 14:04, Andrew Kennedy wrote:
Oops.
I was testing Clocker this morning with the 0.9.0 code, using persistence
and the new SoftLayer VLAN code and have discovered an issue with
RebindManager, which is that if forcePersist is called this gives an NPE if
no persister has been set. The (very simple) fix is in
https://github.com/apache/brooklyn-server/pull/113 which I have just
finished testing, adding the same null check as used elsewhere in the
rebind manager.
Sorry about this, but can we make another RC or is it too late...
Andrew.
On Tue, 12 Apr 2016 at 12:13 Richard Downer <[email protected]> wrote:
The vote for releasing Apache Brooklyn 0.9.0 [rc4] passed with 3 binding
+1s, 1 non-binding +1s, and no 0 or -1.
Vote thread link:
https://mail-archives.apache.org/mod_mbox/brooklyn-dev/201604.mbox/%3CCABQFKi2rBXoGSD5MoAbePJx71RD7KZZx1nbPO-sjuGk45HYvyA%40mail.gmail.com%3E
Binding +1s:
Andrea Turli
Aled Sage
Svetoslav Neykov
Non-binding +1s:
Aleksandr Vasilev
Thanks to everyone that tested our release and voted.
Next, the release manager will publish the artifacts, and make an
announcement to this list once they are available from the Apache mirrors.
Richard.
