Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/109#discussion_r59542960
--- Diff:
utils/common/src/main/java/org/apache/brooklyn/util/ssh/BashCommands.java ---
@@ -235,17 +235,33 @@ public static String onlyIfExecutableMissing(String
executable, String command)
return alternativesGroup(format("which %s", executable), command);
}
- public static String ifExecutableElse(String command, String ifTrue,
String otherwise) {
+ /**
+ * @deprecated As of release 0.9.0, replaced by {@link
#ifExecutableDoesNotExistElse(String, String, String)}
+ */
+ @Deprecated
+ public static String ifExecutableElse(String command, String
ifNotExist, String ifExist) {
+ return ifExecutableDoesNotExistElse(command, ifNotExist, ifExist);
+ }
+
+ public static String ifExecutableDoesNotExistElse(String command,
String ifNotExist, String ifExist) {
return com.google.common.base.Joiner.on('\n').join(
- ifExecutableElse(command,
ImmutableList.<String>of(ifTrue), ImmutableList.<String>of(otherwise)));
+ ifExecutableDoesNotExistElse(command,
ImmutableList.<String>of(ifNotExist), ImmutableList.<String>of(ifExist)));
+ }
+
+ /**
+ * @deprecated As of release 0.9.0, replaced by {@link
#ifExecutableDoesNotExistElse(String, List, List)}
+ */
+ @Deprecated
+ public ImmutableList<String> ifExecutableElse(String command,
List<String> ifNotExist, List<String> ifExist) {
--- End diff --
Should be static.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
