Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/110#discussion_r59546879
--- Diff:
software/winrm/src/main/java/org/apache/brooklyn/location/winrm/WinRmMachineLocation.java
---
@@ -80,6 +81,9 @@
public static final ConfigKey<String> OPERATION_TIMEOUT =
newConfigKeyWithPrefix(BrooklynConfigKeys.BROOKLYN_WINRM_CONFIG_KEY_PREFIX,
WinRmTool.OPERATION_TIMEOUT);
public static final ConfigKey<Integer> RETRIES_OF_NETWORK_FAILURES =
newConfigKeyWithPrefix(BrooklynConfigKeys.BROOKLYN_WINRM_CONFIG_KEY_PREFIX,
WinRmTool.RETRIES_OF_NETWORK_FAILURES);
public static final ConfigKey<Boolean> USE_HTTPS_WINRM =
WinRmTool.USE_HTTPS_WINRM;
+ public static final ConfigKey<String> VERIFY_WINDOWS_UP =
newStringConfigKey("verifyWindowsUp",
+ "Sometimes restart could happen after a Windows VM is
provisioned. This could be because of System Upgrade or other." +
+ " Brooklyn will wait 5 minutes for a restart to happen before
returning the machine as accessible.", null);
--- End diff --
Improve description. Remove mention of 5 minutes - you are not setting a
default value.
Also the code could block for double the time set in this config if the
machine doesn't come back.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
