Github user Graeme-Miller commented on the pull request:
https://github.com/apache/brooklyn-server/pull/128#issuecomment-215378175
Looks good to me, nothing wrong witht he additions as they are following
the pattern already set down by the ComputeServiceImageChooser.
However, I do feel like this class could use a refactor at some point in
the future, to split out the classes/interfaces, and possibly to remove the
instanceof checks. Don't let that hold up this PR though
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
