Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-library/pull/33#discussion_r62216594 --- Diff: software/database/src/main/java/org/apache/brooklyn/entity/database/postgresql/PostgreSqlSshDriver.java --- @@ -328,9 +340,39 @@ private void initializeNewDatabase() { " --command="+ createUserCommand), sudoAsUser("postgres", getInstallDir() + "/bin/psql -p " + entity.getAttribute(PostgreSqlNode.POSTGRESQL_PORT) + " --command="+ createDatabaseCommand), + createRolesAdditionalCommand, callPgctl("stop", true)) .failOnNonZeroResultCode().execute(); } + + private String buildCreateRolesQuery() { + Map<String, Map> roles = entity.getConfig(PostgreSqlNode.ROLES); + String createRolesQuery = "\""; + + for (Map.Entry role: roles.entrySet()) { + createRolesQuery = createRolesQuery.concat(String.format("CREATE ROLE %s", role.getKey())); + if (((Map) role.getValue()).containsKey(PostgreSqlNode.ROLE_PROPERTIES_KEY)) { + createRolesQuery = createRolesQuery.concat(String.format(" WITH %s; ", ((Map) role.getValue()).get("properties"))); + } else { + createRolesQuery = createRolesQuery.concat(";"); + } + + if (((Map) role.getValue()).containsKey(PostgreSqlNode.ROLE_PRIVILEGES_KEY)) { + if ( ((Map) role.getValue()).get(PostgreSqlNode.ROLE_PRIVILEGES_KEY) instanceof List) { + for (Object privilage: (List) ((Map) role.getValue()).get(PostgreSqlNode.ROLE_PRIVILEGES_KEY)) { + createRolesQuery = createRolesQuery.concat(String.format("GRANT %s TO %s; ", privilage, role.getKey())); --- End diff -- s/privilage/privilege
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---