Github user neykov commented on the pull request:
https://github.com/apache/brooklyn-server/pull/134#issuecomment-218148711
LGTM, but note that `makeRandomPassword` has a "special" behaviour in that
it will pick initial characters from all pools and only after that merge them
and select randomly regardless of the pool. Might be better to extend
`makeRandomId` to accept character pools, otherwise all IDs will always follow
the format <letter><number><letter or number>{8}
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
