Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/136#discussion_r63152106
--- Diff:
software/base/src/main/java/org/apache/brooklyn/entity/software/base/InboundPortsUtils.java
---
@@ -77,12 +82,17 @@
Set<ConfigKey<?>> configKeys =
Sets.newHashSet(extraConfigKeys);
configKeys.addAll(entity.getEntityType().getConfigKeys());
// Also add dynamically added config keys
-
configKeys.addAll(((EntityInternal)entity).config().getBag().getAllConfigAsConfigKeyMap().keySet());
+ Map<ConfigKey<?>, ?> configuredConfigKeys =
ImmutableMap.copyOf(((EntityInternal)
entity).config().getBag().getAllConfigAsConfigKeyMap());
+ configKeys.addAll(configuredConfigKeys.keySet());
+
+ if (portRegex == null) {
+ portRegex = ".*\\.port"; // defaults to legacy regex if
not specified
+ }
--- End diff --
please avoid whitespace changes, import reorgs (I know you know this now!),
and preference style changes like the above (if it's an egregiously bad style
change it)
those things all make PR's harder to review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
