Github user neykov commented on the pull request:
https://github.com/apache/brooklyn-server/pull/142#issuecomment-220265656
Looks good, nice test coverage. What do you think about adding an option to
reverse the test - successful if can't connect (for example by adding
`assertFails: true`). It's as useful doing the reverse check.
Current implementation of `Networking.isReachable` might take a while to
give up if the port is not reachable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
