Github user aledsage commented on the pull request:

    https://github.com/apache/brooklyn-server/pull/132#issuecomment-220478329
  
    Rebasing fixed the problem in my test where 
`assertEquals(machine.getUser(), "myuser");` was failing (so that is now 
uncommented). I hope that whatever fixed that issue will have fixed @johnmccabe 
's "NPE when deploying an app to a JcloudsByonLocation".
    
    For "NPE when deploying a docker infrastructure via Clocker", that has been 
fixed in a separate PR by the looks of it (certainly we guard against that 
NPE). See commit bee832d139bdaffffb859278ef6eeddd93085838.
    
    I've confirmed that it works with username using 
`JcloudsByonLocationResolverAwsLiveTest` (though I needed to fix another couple 
of things there - see second commit).
    
    @johnmccabe can you review / test again with this latest code when you get 
a chance?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to