Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/150#discussion_r64442720
--- Diff:
software/base/src/main/java/org/apache/brooklyn/entity/software/base/VanillaWindowsProcess.java
---
@@ -76,6 +76,10 @@
@CatalogConfig(label = "Stop Command", priority=1)
ConfigKey<String> STOP_COMMAND = VanillaSoftwareProcess.STOP_COMMAND;
+ @CatalogConfig(label = "Suppress failures occurred during
installation. When using this parameter, Apache Brooklyn relies that your
blueprint will report failures on the check running phase.")
+ ConfigKey<Boolean> SUPPRESS_INSTALL_FAILURE =
ConfigKeys.newBooleanConfigKey("install.windows.suppressFailure", "Suppress any
installation failure. It is a common case to restart windows together with the
installation process." +
+ " In such case, it's hard to tell when the install command
finished and entered into restart and you may want to support connectivity or
other failures.", false);
--- End diff --
Put the `, false` on a new line. Otherwise someone reading through the code
will miss it (unless they scroll).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
