GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/164
Update ConfigMapTest
* Updates the config tests (in particular `ConfigMapTest` was still calling
entity constructors).
* Merges `ConfigMapTest` and `EntityConfigTest`, because there was no clear
difference for what the tests were covering - so risked duplication if people
didn't look in both.
* Deletes EntityConfigMapUsageLegacyTest, which tested the old (defunct)
way of creating an entity via its constructor - everything (except some old
tests) should now use EntitySpec.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server update/ConfigMapTest
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/164.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #164
----
commit 219803d2a95a7f4b801caa9ac709cd8848ac1cb6
Author: Aled Sage <[email protected]>
Date: 2016-05-27T23:13:36Z
Update ConfigMapTest and related tests
Previously it called the entity constructors; changed to use
EntitySpec.
commit 0860bfe197de722e1f57dbc1b3942527e04866a4
Author: Aled Sage <[email protected]>
Date: 2016-05-27T23:40:26Z
Merge ConfigMapTest into EntityConfigTest
commit de126c37602514f0e96adc3fd7571078fe92e0bc
Author: Aled Sage <[email protected]>
Date: 2016-05-27T23:48:09Z
Rename EntityConfigMapUsageTest to EntityConfigUsageTest
commit 28baad6b658c75dd0bb8d6b979ebbf063734b556
Author: Aled Sage <[email protected]>
Date: 2016-05-27T23:49:53Z
Delete EntityConfigMapUsageLegacyTest
This tested the creation of entities via the constructor (rather than
using EntitySpec). That approach has been deprecated for a very long
time, and is no longer supported. (But it is still used in some old
tests).
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
