Github user aledsage commented on the pull request:
https://github.com/apache/brooklyn-server/pull/144#issuecomment-222313156
Worth adding test case(s).
(ping me offline if you want to talk about how best to write good unit-test
coverage for this).
Also note the related discussion the mailing list. An alternative
suggestion is that we pick up *all* files with the given name on the classpath
(rather than all those in a given directory). I personally prefer the approach
of all files in the directory. That would allow us to more easily incrementally
add things (e.g. have separate files for upgrading between versions).
---
I wonder about a nicer package name than
`org.apache.brooklyn.core.mgmt.persist.deserializingClassRenames`. I imagine
many people will just put this in their `./conf/` directory, so we don't want
them to have to create a really deep nested directory.
---
Another thing we could add (in the future?) is if there are conflicting
changes - e.g. A is renamed to B in the first file, and B is renamed to C in
the second file. Currently, the result would depend on the other the files were
processed: i.e. it could be "B" or "C". It would be good to be more predictable.
I'm fine with that being deferred for now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
