Github user nakomis commented on the pull request:
https://github.com/apache/brooklyn-server/pull/157
This looks sensible, but it would be nice to tidy it up as follows:
- Rename `brooklyn-invoke-command-credssp.ps1` to
`invoke-command-credssp.ps1`
- Rename `custom-enable-credssp.ps1` to `enable-credssp.ps1`
- Move the scripts from `org/apache/brooklyn/software/base` to
`org/apache/brooklyn/software/winrm/utils`
- Rather than call `C:\invoke-command-credssp.ps1 -Command "my arguments"`,
instead have `invoke-command-credssp.ps1` export a function such as
`Invoke-Command-Credssp`, which would then be consumed by importing the
function and calling `Invoke-Command-Credssp "my arguments"`
- Create a config key `ENABLE_CRED_SSP`, which would run
`enable-credssp.ps1` once and once only prior to any other scripts being run.
I'm tempted to say make this default to true (but allow it to be set to false
for security reasons). This could also be used to automatically copy the
`invoke-command-credssp.ps1` script to an appropriate location and prepend the
installation scripts with the appropriate import for `Invoke-Command-Credssp`
- Copy `invoke-command-credssp.ps1` and `enable-credssp.ps1` to a more
appropriate location than `C:\`â , such as
`$HOME\brooklyn-managed-processes\scripts` (I'm not sure of the syntax or exact
location of this on Windows)
â The use of `C:\` was a poor choice of location by the original
blueprint developer (me), and shouldn't have made it into production. It would
be nice to change the destination of _all_ of the installation scripts, but for
now, I think it's more important to find a suitable home for these two scripts
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
