Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/169#discussion_r65270710
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
---
@@ -931,14 +960,23 @@ protected MachineLocation obtainOnce(ConfigBag setup)
throws NoMachinesAvailable
for (String rule : iptablesRules) {
batch.add(rule);
if (batch.size() == 50) {
-
((SshMachineLocation)machineLocation).execCommands("Inserting iptables rules,
50 command batch", batch);
+ executeCommandWarningOnError(
+
(SshMachineLocation)machineLocation,
+ "Inserting iptables rules, 50
command batch",
+ batch);
batch.clear();
}
}
if (batch.size() > 0) {
-
((SshMachineLocation)machineLocation).execCommands("Inserting iptables rules",
batch);
+ executeCommandWarningOnError(
+
(SshMachineLocation)machineLocation,
+ "Inserting iptables rules",
+ batch);
}
-
((SshMachineLocation)machineLocation).execCommands("List iptables rules",
ImmutableList.of(IptablesCommands.listIptablesRule()));
+ executeCommandWarningOnError(
--- End diff --
On balance I agree with this, but I suspect it will affect some people who
have config for `openIptables` irrespective of the various distros. But we can
certainly live with that.
We definitely need to remember to put in the release notes for 0.10.0 that
we now throw errors on failure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
