Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/173#discussion_r65524870
--- Diff:
utils/common/src/main/java/org/apache/brooklyn/config/ConfigInheritance.java ---
@@ -20,31 +20,60 @@
import java.io.Serializable;
+import org.apache.brooklyn.util.text.Strings;
+
import com.google.common.annotations.Beta;
@SuppressWarnings("serial")
public abstract class ConfigInheritance implements Serializable {
- public static final ConfigInheritance ALWAYS = new Always();
+ public enum InheritanceMode {
--- End diff --
I don't like the use of `ConfigInheritance` and `InheritanceMode`. It feels
like we should just have one thing, particularly given the existing
implementations of `ConfigInheritance` are so simple. But `ConfigInheritance`
is not `@Beta` so I'm being conservative about changing that.
Any suggestions for a cleaner way?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
