Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/185#discussion_r66146520
--- Diff:
rest/rest-resources/src/main/java/org/apache/brooklyn/rest/transform/EffectorTransformer.java
---
@@ -83,7 +84,8 @@ public static EffectorSummary
effectorSummaryForCatalog(Effector<?> effector) {
.context(entity).timeout(ValueResolver.REAL_QUICK_WAIT).getMaybe();
return new ParameterSummary(parameterType.getName(),
parameterType.getParameterClassName(),
parameterType.getDescription(),
- WebResourceUtils.getValueForDisplay(defaultValue.orNull(),
true, false));
+ WebResourceUtils.getValueForDisplay(defaultValue.orNull(),
true, false),
+
Sanitizer.IS_SECRET_PREDICATE.apply(parameterType.getName()));
--- End diff --
It looks like you added `parameterType.isSensitive`, but then don't use it
here (and instead rely on `Sanitizer`). As I said in earlier comment, I think
that's fine - in fact probably best to delete `isSensitive` if we're not going
to use it everywhere.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
