Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/226#discussion_r69454029
  
    --- Diff: 
core/src/main/java/org/apache/brooklyn/core/entity/EntityAsserts.java ---
    @@ -223,4 +225,14 @@ public void run() {
             });
         }
     
    +    public static void assertServiceFailed(Entity test) {
    +        assertFalse(test.sensors().get(SERVICE_UP), "Service should be 
down");
    --- End diff --
    
    I prefer the error message you'd get if you called 
`assertAttributeEquals(test, SERVICE_UP, false)`. That would also cope better 
with the sensor being null, giving us a nicer message.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to