Github user bostko commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/211#discussion_r70606525
--- Diff:
software/base/src/main/java/org/apache/brooklyn/entity/software/base/lifecycle/MachineLifecycleEffectorTasks.java
---
@@ -709,7 +712,26 @@ protected void doStop(ConfigBag parameters,
Callable<StopMachineDetails<Integer>
DynamicTasks.queue("pre-stop", new PreStopCustomTask());
+ // BROOKLYN-263:
+ // With this change the stop effector will wait for Location to
provision so it can stop it.
+ // It will not retry if non-jclouds location is used in the entity.
Maybe<MachineLocation> machine =
Machines.findUniqueMachineLocation(entity().getLocations());
+ if
(Boolean.TRUE.equals(entity().sensors().get(Attributes.JCLOUDS_PROVISIONING_STARTED))
+ && machine.isAbsent()) {
+
entity().sensors().set(Attributes.JCLOUDS_PROVISIONING_STARTED, null);
--- End diff --
@aledsage do you have an idea how can I tell the stop task that the
provisioning started other than the sensor flag. I feel like the code will need
serious refactoring in order stop task to know earlier about the jclouds node.
The entity knows only about the machine location. It doesn't know about the
LocationProvisioner.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
