Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/229#discussion_r70798405
--- Diff:
core/src/main/java/org/apache/brooklyn/core/objs/BasicSpecParameter.java ---
@@ -384,5 +387,34 @@ public static WeightedParameter
getFieldConfig(ConfigKey<?> config, Field config
}
}
+ /**
+ * Adds the given list of {@link SpecParameter parameters} to the
provided
+ * {@link AbstractBrooklynObjectSpec spec}. Inherits parent parameters
except
+ * where there is an existing {@link ConfigKey config key}.
+ * <p>
+ * Implemented by explicitly replacing the existing parameters with an
+ * updated list.
+ *
+ * @see EntitySpec#parameters(List)
+ */
+ public static void addParameters(AbstractBrooklynObjectSpec<?, ?>
spec, List<? extends SpecParameter<?>> explicitParams,
BrooklynClassLoadingContext loader) {
+ if (explicitParams.size() > 0) {
--- End diff --
Shouldn't be one or the other, but both instead. First add from spec (if no
spec parameters), then merge with explicit parameters.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
