Github user aledsage-tmp commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/261#discussion_r71111585
--- Diff:
test-framework/src/main/java/org/apache/brooklyn/test/framework/RelativeEntityTestCase.java
---
@@ -52,12 +51,14 @@
@ImplementedBy(RelativeEntityTestCaseImpl.class)
public interface RelativeEntityTestCase extends TargetableTestComponent {
+ @SetFromFlag("anchor")
AttributeSensorAndConfigKey<Entity, Entity> ANCHOR =
ConfigKeys.newSensorAndConfigKey(Entity.class,
- "anchor",
+ "test.anchor.entity",
--- End diff --
I don't think we should rename all these. The semantics for SetFromFlag is
different (for inheritance) so this is not backwards compatible. I think we
should leave as-is. The old name was fine. We don't need to make the key names
"slightly unique".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
