Github user aledsage-tmp commented on the issue:

    https://github.com/apache/brooklyn-server/pull/264
  
    There are 114 changed/added files. That seems excessive (though struggling 
to review properly on iPad because of that).
    
    Instead of checking in an entire persisted state folder (eg including 
brooklyn-server/launcher/src/test/resources/orphaned-locations-test-data/data-without-orphaned-locations/catalog/org.apache.brooklyn.entity.cm.ansible.AnsibleEntity_0.10.0-SNAPSHOT),
 I'd recommend we have far more focused test cases with just a minimal file. Or 
even construct the persisted state on the fly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to