Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/280#discussion_r72853888
  
    --- Diff: 
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/BrooklynEntityDecorationResolver.java
 ---
    @@ -180,20 +182,23 @@ protected void addDecorationFromJsonMap(Map<?, ?> 
decorationJson, List<EntityIni
         // Not much value from extending from 
BrooklynEntityDecorationResolver, but let's not break the convention
         public static class SpecParameterResolver extends 
BrooklynEntityDecorationResolver<SpecParameter<?>> {
     
    +        private Function<Object, Object> transformer;
    +
             protected 
SpecParameterResolver(BrooklynYamlTypeInstantiator.Factory instantiator) { 
super(instantiator); }
     
             @Override
             protected String getDecorationKind() { return "Spec Parameter 
initializer"; }
     
             @Override
    -        public void decorate(EntitySpec<?> entitySpec, ConfigBag attrs) {
    +        public void decorate(EntitySpec<?> entitySpec, ConfigBag attrs, 
Set<String> encounteredRegisteredTypeIds) {
    +            transformer = new 
BrooklynComponentTemplateResolver.SpecialFlagsTransformer(instantiator.loader, 
encounteredRegisteredTypeIds);
    --- End diff --
    
    Would it work if you transform `attrs` before passing it to 
`BasicSpecParameter.fromConfigList` so it doesn't need to know about the 
`transformer`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to