[
https://issues.apache.org/jira/browse/BROOKLYN-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15400675#comment-15400675
]
ASF GitHub Bot commented on BROOKLYN-249:
-----------------------------------------
Github user grkvlt commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/279#discussion_r72888151
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
---
@@ -527,7 +531,7 @@ public ComputeService getComputeService(Map<?,?> flags)
{
public ComputeService getComputeService(ConfigBag config) {
ComputeServiceRegistry registry =
getConfig(COMPUTE_SERVICE_REGISTRY);
- return
registry.findComputeService(ResolvingConfigBag.newInstanceExtending(getManagementContext(),
config), true);
--- End diff --
By the time `getComputeService()` is called, I will already have set up the
`ConfigBag` to be a resolving config, see `private ConfigBag
getConfigBag(Map<?, ?> flags)` method below. The addition of a new
`ResolvingConfigBag` was redundant. In essence I'm solving the same problem as
**BROOKLYN-249** and also adding the ability to resolve config through the
calling entity context, if it exists.
> errors using external config for JcloudsLocation
> ------------------------------------------------
>
> Key: BROOKLYN-249
> URL: https://issues.apache.org/jira/browse/BROOKLYN-249
> Project: Brooklyn
> Issue Type: Bug
> Reporter: Aled Sage
> Assignee: Aled Sage
> Fix For: 0.9.0
>
>
> Using 0.10.0-SNAPSHOT (also affecting 0.9.0-rc2), I hit problems using
> external config with JcloudsLocation.
> First it failed to resolve the external config for the ssh publicKeyData and
> privateKeyData.
> After fixing that, it failed to rebind to my persisted state that included
> the external config in the location (it tried to coerce the
> {{DeferredSupplier}} to a String).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
