Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-library/pull/55#discussion_r73174941
  
    --- Diff: 
software/webapp/src/main/java/org/apache/brooklyn/entity/proxy/AbstractControllerImpl.java
 ---
    @@ -287,7 +287,7 @@ protected String inferUrl(boolean 
requireManagementAccessible) {
         }
     
         protected String inferUrl() {
    -        return inferUrl(false);
    +        return inferUrl(true);
    --- End diff --
    
    This doesn't feel right - it will mean that "main.uri" will have the 
publicly mapped address (e.g. if running in vCloud Director behind a DNAT rule 
then it will show the dnat'ed port).
    
    That contradicts the proposal in dev@brooklyn (email subject "Working with 
Multiple Networks - Apache Brooklyn Feature Proposal", link to proposal is 
    
https://docs.google.com/document/d/1IrWLWunWSl_ScwY3MRICped8eJMjQEH1FbWZJcoK0Iw).
 That proposal says the main.uri should be the subnet address.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to