Github user sjcorbett commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/288#discussion_r73669172
  
    --- Diff: 
rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/LogoutResource.java
 ---
    @@ -37,32 +37,44 @@
         @Context UriInfo uri;
     
         @Override
    +    public Response redirectToLogout() {
    +        URI dest = uri.getBaseUriBuilder().path(LogoutApi.class).build();
    +
    +        return Response.status(Status.OK)
    +                .entity(String.format("<!DOCTYPE html>\n<body>\n" +
    +                        "<script>\n" +
    +                        "(function(c){var a=new window.XMLHttpRequest;" +
    +                        // 
https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/open
    --- End diff --
    
    Could you also add a comment describing what the purpose of the two lines 
below? Inconvenient to have to piece it together from the Mozilla link. And 
(nitpick) is there any reason it needs to be so densely formatted?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to