Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/291#discussion_r74491894
  
    --- Diff: 
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/ObjectsYamlTest.java
 ---
    @@ -275,6 +288,57 @@ public void testBrooklynObjectWithFunction() throws 
Exception {
             Assert.assertTrue(testObjectObject instanceof SimpleTestPojo, 
"Expected a SimpleTestPojo: "+testObjectObject);
         }
     
    +    @Test
    +    public void testBrooklynObjectWithParameterisedConstructor() throws 
Exception {
    --- End diff --
    
    Looks good. Would also be nice to have a test that used a deferred 
supplier. But given there are no existing tests in `ObjectsYamlTest` that do 
that, I see why you didn't either!
    
    We can do that in a separate PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to