Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/304#discussion_r75630441
--- Diff:
core/src/main/java/org/apache/brooklyn/enricher/stock/Enrichers.java ---
@@ -293,42 +307,33 @@ protected String getDefaultUniqueTag() {
return "aggregator:"+publishing.getName();
}
public EnricherSpec<?> build() {
- Predicate<Object> valueFilter;
--- End diff --
won't removing this break every aggregator which relies on `valueFilter` to
deliver `excludingBlank` behaviour?
is it better to keep the if block and fail if both value-filter and
excluding blank are set (or construct a new `and` filter) ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
