Github user grkvlt commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/308#discussion_r76399739
--- Diff:
core/src/main/java/org/apache/brooklyn/entity/group/SshCommandMembershipTrackingPolicy.java
---
@@ -61,11 +64,16 @@
* executed. This can be one of: the {@link ExecutionTarget#ENTITY owing
entity};
* the {@link ExecutionTarget#MEMBER member} that was updated; or
* {@link ExecutionTarget#ALL_MEMBERS all members} of the group.
+ *
+ * @deprecated introduced and removed in 0.10.0-snapshot; use a
combination of
+ * InvokeEffectorOnSensorChange and SshCommandEffector instead
+ * (much simpler semantics as you normally will want to listen to a local
sensor
+ * (which in turn is aggregated over members) instead of children sensors
directly).
+ * If there is a need for {@link #EVENT_TYPE} or {@link #MEMBER_ID} then
we'll want
+ * InvokeEffectorOnSensorChange to be able to subscribe to
members/children etc as well,
+ * and pass parameters based on source.entityId and source.sensor.
*/
-// TODO might make sense to split up behaviour into two classes,
-// an InvokeEffectorMembershipTrackingPolicy and an
SshMultiEntityCommandEffector --
-// where the latter has the configurable target introduced here
-@Beta
+@Deprecated
--- End diff --
Actually, this could be safely removed, since the only usage of it has been
updated to use the new policy defined here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
