Github user drigodwin commented on a diff in the pull request:

    https://github.com/apache/brooklyn-docs/pull/108#discussion_r79150922
  
    --- Diff: guide/ops/osgi-configuration.md ---
    @@ -1,79 +1,62 @@
     ---
    -title: OSGi Distribution
    +title: OSGi Configuration
     layout: website-normal
     ---
     
    -# Running Apache Brooklyn inside Karaf container
    +Configuration of Brooklyn when running under Karaf is largely done through 
standard Karaf mechanisms. 
    +The Karaf "Configuration Admin" subsystem is used to manage configuration 
values loaded at first boot from the
    +`.cfg` files in the `etc` directory of the distribution. In the Karaf 
command line these can then be viewed
    +and manipulated by the `config:` commands, see the Karaf documentation for 
full details.
     
    -The Apache Brooklyn Karaf based distribution lives in 
brooklyn-server/karaf/apache-brooklyn folder.
    -It's still in a testing stage so some features might not work as expected. 
Do reach out if you
    -find any problems.
    +## Configuring Brooklyn Properties
     
    -## Building
    -
    -{% highlight bash %}
    -cd brooklyn-server
    -mvn clean install
    -cd karaf/apache-brooklyn/target
    -tar -zxvf apache-brooklyn-{{ site.brooklyn-version }}.tar.gz
    -cd apache-brooklyn-{{ site.brooklyn-version }}
    -{% endhighlight %}
    -
    -## Running
    -
    -Start the instance using the following command
    -
    -{% highlight bash %}
    -bin/karaf
    -{% endhighlight %}
    -
    -This will launch the [Karaf 
console](https://karaf.apache.org/manual/latest/users-guide/console.html)
    -where you can interact with the running instance. Note that Brooklyn has 
already started at this point
    -and is reachable at the usual web console url.
    -
    -To start in debug mode use
    -
    -{% highlight bash %}
    -bin/karaf debug
    -{% endhighlight %}
    -
    -and connect to port 5005 using your debugger.
    -
    -To pause startup until the debugger is connected you can use
    -
    -{% highlight bash %}
    -JAVA_DEBUG_OPTS='-Xdebug -Xnoagent -Djava.compiler=NONE 
-Xrunjdwp:transport=dt_socket,server=y,suspend=y,address=5005' bin/karaf debug
    -{% endhighlight %}
    -
    -The Karaf container will keep state like installed bundles and 
configuration between restarts.
    -To reset any changes add **clean** to the cli arguments.
    -
    -## Configuring
    -
    -To configure the Brooklyn runtime create an **etc/brooklyn.cfg** file, 
following the standard **brooklyn.properties**
    +To configure the Brooklyn runtime create an `etc/brooklyn.cfg` file, 
following the standard `brooklyn.properties`
    --- End diff --
    
    I think the ** links out to the file? This should link out to the 
brooklyn.properties page I think


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to