Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/332#discussion_r79451817
  
    --- Diff: 
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsUtil.java
 ---
    @@ -354,6 +355,13 @@ public static String 
getFirstReachableAddress(ComputeServiceContext context, Nod
         }
         
         public static String getFirstReachableAddress(NodeMetadata node, 
Duration timeout) {
    +        return getFirstReachableAddress(node, timeout, new 
Predicate<HostAndPort>() {
    +            @Override public boolean apply(HostAndPort input) {
    +                return Networking.isReachable(input);
    +            }});
    +    }
    --- End diff --
    
    This is the same predicate as in the other file. Reuse, avoid anonymous 
classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to