Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/340#discussion_r79991034
  
    --- Diff: 
core/src/main/java/org/apache/brooklyn/core/config/ConfigKeys.java ---
    @@ -46,6 +47,9 @@
     
         private static final Logger log = 
LoggerFactory.getLogger(ConfigKeys.class);
         
    +    public enum InheritanceContext implements ConfigInheritanceContext
    +    { TYPE_DEFINITION, RUNTIME_MANAGEMENT } 
    --- End diff --
    
    Personal preference: strange code layout! Can we follow a common coding 
convention (like that of Oracle, with our agreed variations like line length) 
when there's not a really good reason to deviate?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to