Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/318#discussion_r80026503
  
    --- Diff: 
core/src/main/java/org/apache/brooklyn/core/location/access/PortForwardManagerImpl.java
 ---
    @@ -83,9 +83,6 @@
     
         private final Map<AssociationListener, Predicate<? super 
AssociationMetadata>> associationListeners = new 
ConcurrentHashMap<AssociationListener, Predicate<? super 
AssociationMetadata>>();
     
    -    @Deprecated
    -    protected final Map<String,String> publicIpIdToHostname = new 
LinkedHashMap<String,String>();
    --- End diff --
    
    @sjcorbett my strategy when deprecating fields is to mark it deprecated and 
transient for one major release, make sure all accessors transform it, and make 
sure at least one accessor gets exercised.
    
    this should ensure that if state from one version is carried through 
subsequent major versions it will migrate.
    
    however there is not currently any way to force exercising in all cases i 
don't think (we could introduce a method `postRebind()` for that purpose?).  
for now i suggest keep it in perpetuity with a comment `// kept for persistence 
from previous versions; see https://github.com/apache/brooklyn-server/pull/318`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to