Github user ahgittin commented on the issue:

    https://github.com/apache/brooklyn-server/pull/337
  
    failure is unrelated
    
    intention makes sense
    
    however this will do nothing as deep_merge only applies to maps.
    
    with #340 you could relatively easily introduce a new 
`COLLECTION_ANCESTORS_FIRST` or `COLLECTION_ANCESTORS_LAST` into 
`BasicConfigInheritance` which would make sense for sets or lists (but with 
different semantics).  or maybe simpler change the `deepMerge` method in that 
class to support collections, probably adding ancestors last.
    
    that change plus a test for this commit which tests that change would be 
welcome.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to