[ 
https://issues.apache.org/jira/browse/BROOKLYN-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15523527#comment-15523527
 ] 

ASF GitHub Bot commented on BROOKLYN-350:
-----------------------------------------

Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-library/pull/64#discussion_r80515706
  
    --- Diff: 
software/database/src/main/java/org/apache/brooklyn/entity/database/postgresql/PostgreSqlNode.java
 ---
    @@ -52,13 +52,17 @@
     public interface PostgreSqlNode extends SoftwareProcess, HasShortName, 
DatastoreCommon, DatabaseNode {
         
         @SetFromFlag("version")
    -    ConfigKey<String> SUGGESTED_VERSION = 
ConfigKeys.newConfigKeyWithDefault(SoftwareProcess.SUGGESTED_VERSION, 
"9.3-1");//"9.1-4");
    +    ConfigKey<String> SUGGESTED_VERSION = 
ConfigKeys.newConfigKeyWithDefault(SoftwareProcess.SUGGESTED_VERSION, 
"9.3-3");//"9.1-4");
     
         @SetFromFlag("configFileUrl")
         ConfigKey<String> CONFIGURATION_FILE_URL = 
ConfigKeys.newStringConfigKey(
                 "postgresql.config.file.url", "URL where PostgreSQL 
configuration file can be found; "
                     + "if not supplied the blueprint uses the default and 
customises it");
     
    +    @SetFromFlag("curlCommand")
    +    ConfigKey<String> CURL_COMMAND = ConfigKeys.newStringConfigKey(
    +            "curl.command", "cURL comamnd to be used. It follows location 
redirects by default (added -L parameter)", "curl -L");
    --- End diff --
    
    +1 could even do away with the config altogether - that's not something 
I've ever seen needing configuration. No strong opinion though.


> Upstream yum repos for PostgresSQL started to enforce HTTPS
> -----------------------------------------------------------
>
>                 Key: BROOKLYN-350
>                 URL: https://issues.apache.org/jira/browse/BROOKLYN-350
>             Project: Brooklyn
>          Issue Type: Dependency upgrade
>            Reporter: Yavor Yanchev
>
> The upstream YUM repos [1] provided by the PostgreSQL project started to 
> enforce HTTPS.
> The PostgreSqlSshDriver uses curl to download RPMs from the upstream repo 
> URL, but fails because it is redirected to the HTTPS location using a 
> standard 301 header and curl is not instructed to follow the redirects.
> Example curl output
> {code}
> < HTTP/1.1 301 Moved Permanently
> < Location: 
> https://yum.postgresql.org/9.4/redhat/rhel-6-x86_64/pgdg-centos94-9.4-2.noarch.rpm
> {code}
> If curl is instructed to follow the redirects with -L (--location) option the 
> download will be successful 
> [1] http://yum.postgresql.org



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to