Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/331#discussion_r80631955
--- Diff:
core/src/main/java/org/apache/brooklyn/core/mgmt/internal/BrooklynGarbageCollector.java
---
@@ -92,16 +93,28 @@
Duration.minutes(1));
public static final ConfigKey<Boolean> DO_SYSTEM_GC =
ConfigKeys.newBooleanConfigKey(
- "brooklyn.gc.doSystemGc", "whether to periodically call
System.gc()", false);
-
+ "brooklyn.gc.doSystemGc", "whether to periodically call
System.gc()", false);
+
+ public static final ConfigKey<Double>
FORCE_CLEAR_SOFT_REFERENCES_ON_MEMORY_USAGE_LEVEL =
+
ConfigKeys.newDoubleConfigKey("brooklyn.gc.clearSoftReferencesOnMemoryUsageLevel",
+ "force clearance of soft references (by generating a
deliberate OOME) "
+ + "if memory usage gets higher than this percentage of
available memory; "
+ + "Brooklyn will use up to the max, or this percentage, with
soft references,"
+ + "so if using any high-memory-usage alerts they should be
pegged quite a bit"
+ + "higher than this threshhold "
+ + "(default >1 means never)", 2.0);
--- End diff --
The default an unusual way of saying never. `null` is the non-surprising
value for this case, even if it complicates the code a bit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
