[
https://issues.apache.org/jira/browse/BROOKLYN-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15529072#comment-15529072
]
ASF GitHub Bot commented on BROOKLYN-325:
-----------------------------------------
GitHub user iyovcheva opened a pull request:
https://github.com/apache/brooklyn-server/pull/356
BROOKLYN-325 Rebind entity starting (initial PR)
This partially fixes BROOKLYN-325 - when server restarts while entity is
starting or stopping, on rebind it will now go on fire instead of reporting the
entity's sensors as starting/stopping.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/iyovcheva/brooklyn-server
rebind-entity-starting
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/356.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #356
----
commit 001b02cdaeb5f6686ba57dc81cb0e30d4fc34dd7
Author: Ivana Yovcheva <[email protected]>
Date: 2016-09-23T02:38:46Z
BROOKLYN-325 Set starting/stopping entity on fire on rebind
commit 5d252d7ef1ec3f35ce874c05db95c9db2d9e2774
Author: Aled Sage <[email protected]>
Date: 2016-09-26T21:13:38Z
Add tests to SoftwareProcessRebindNotRunningEntityTest
commit 5906fb30604979bb524cfc61ea4c376492d5112a
Author: iyovcheva <[email protected]>
Date: 2016-09-28T08:22:19Z
Merge pull request #4 from aledsage/iyovcheva-aled/rebind-entity-starting
Add tests to SoftwareProcessRebindNotRunningEntityTest
----
> Restarting Brooklyn while entity deploying: entity shown as deploying
> indefinitely
> ----------------------------------------------------------------------------------
>
> Key: BROOKLYN-325
> URL: https://issues.apache.org/jira/browse/BROOKLYN-325
> Project: Brooklyn
> Issue Type: Bug
> Affects Versions: 0.9.0
> Reporter: Aled Sage
>
> When the Brooklyn server restarts while an entity is halfway through starting
> or stopping, on rebind that entity continues to report its sensor as
> starting/stopping. However, the task does not resume so it stays in this
> state indefinitely.
> To reproduce, run Brooklyn with persistence enabled, and try deploying a
> blueprint like that below:
> {noformat}
> location: localhost
> services:
> - type: org.apache.brooklyn.entity.software.base.VanillaSoftwareProcess
> brooklyn.config:
> launch.command: sleep 20
> stop.command: sleep 20
> checkRunning.command: true
> {noformat}
> While the app is starting, terminate the Brooklyn server and then restart it.
> In the UI, the spinning icon shows that the app is still deploying. The
> entity has the following sensor values:
> {noformat}
> service.isUp: false
> service.notUp.indicators: {"service.process.isRunning":"No information on
> whether this service is running"}
> service.state: STARTING
> service.state.expected: starting @ 1470658910966 / Mon Aug 08 13:21:50 BST
> 2016
> {noformat}
> Alternatively, deploy the app normally and then invoke stop. While the app is
> stopping, terminate the Brooklyn server and then restart it. The entity has
> the following sensor values:
> {noformat}
> service.process.isRunning: false
> service.state: STOPPING
> service.state.expected: stopping @ 1470658816662 / Mon Aug 08 13:20:16 BST
> 2016
> {noformat}
> Given that the task won't resume, I'd expect the entity to be marked as
> having some kind of error. For example, the service.state as on-fire (but
> ideally without losing the fact that it was previously stopping).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
