Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/323#discussion_r80933164
  
    --- Diff: 
utils/common/src/main/java/org/apache/brooklyn/util/exceptions/Exceptions.java 
---
    @@ -461,4 +461,14 @@ public static String 
getMessageWithAppropriatePrefix(Throwable t) {
             return appendSeparator(getPrefixText(t), t.getMessage());
         }
     
    +    /** Returns true if the root cause is a "boring" CNF, ie a 
straightforward declaration that the clazz is not found;
    +     * this permits callers to include the cause only when it is 
interesting, ie caused by a dependent class not loadable.
    +     */
    +    public static boolean isRootBoringClassNotFound(Exception e, String 
clazz) {
    +        Throwable root = Throwables.getRootCause(e);
    +        if (!(root instanceof ClassNotFoundException)) return false;
    --- End diff --
    
    possibly, at least if it has no useful message.  i think maybe sometimes 
that one can have an interesting message?  wait until we see it occurring 
without clutter.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to