Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/359#discussion_r81085479
--- Diff:
utils/common/src/main/java/org/apache/brooklyn/util/text/Identifiers.java ---
@@ -168,9 +168,11 @@ public static String makeRandomPassword(final int
length, String... passwordVali
return Joiner.on("").join(list);
}
+ @SuppressWarnings({ "rawtypes", "unchecked" })
protected static String mergeCharacterSets(String... s) {
Set characters = new HashSet<Character>();
for (String characterSet : s) {
+ // more efficient to lose the generics here
--- End diff --
What does this comment mean? Given that Java uses erasure (except in very
special cases!) then how is it more efficient to lose the generics?
It looks like the generics are wrong: it should be `Set<String>`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
