Github user sjcorbett commented on a diff in the pull request:
    --- Diff: 
    @@ -76,6 +79,14 @@
         private RangeSet<Integer> udpPortRanges;
    +     * Tested only on AWS only.
    +     * It depends on the cloud provider and jclouds driver whether 
security group allows opening ICMP.
    +     */
    +    private Boolean openIcmp;
    +    private Collection<SecurityGroup> updatedSecurityGroups;
    --- End diff --
    Delete this and `getUpdatedSecurityGroups` and add a new method to the 
class (not sure of the best name for it, maybe simply `doCustomize`?) that 
performs the customisation and returns the new security groups. 
`customize(JcloudsLocation, ComputeService, JcloudsMachineLocation)` should 
call this new method and discard the result.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

Reply via email to