Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/386#discussion_r84929449
--- Diff:
core/src/main/java/org/apache/brooklyn/policy/AbstractInvokeEffectorPolicy.java
---
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.brooklyn.policy;
+
+import java.util.Map;
+import java.util.concurrent.atomic.AtomicInteger;
+import javax.annotation.Nonnull;
+
+import org.apache.brooklyn.api.effector.Effector;
+import org.apache.brooklyn.api.entity.EntityLocal;
+import org.apache.brooklyn.api.mgmt.Task;
+import org.apache.brooklyn.api.sensor.AttributeSensor;
+import org.apache.brooklyn.config.ConfigKey;
+import org.apache.brooklyn.core.config.ConfigKeys;
+import org.apache.brooklyn.core.policy.AbstractPolicy;
+import org.apache.brooklyn.core.sensor.Sensors;
+import org.apache.brooklyn.util.guava.Maybe;
+import org.apache.brooklyn.util.text.Strings;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import com.google.common.util.concurrent.MoreExecutors;
+
+public abstract class AbstractInvokeEffectorPolicy extends AbstractPolicy {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(AbstractInvokeEffectorPolicy.class);
+
+ public static final ConfigKey<String> IS_BUSY_SENSOR_NAME =
ConfigKeys.newStringConfigKey(
+ "isBusySensor",
+ "Name of the sensor to publish on the entity that indicates
that this policy has incomplete effectors. " +
+ "If unset running tasks will not be tracked.");
+
+ private final AtomicInteger taskCounter = new AtomicInteger();
+
+ @Override
+ public void setEntity(EntityLocal entity) {
+ super.setEntity(entity);
+ if (isBusySensorEnabled()) {
+ // Republishes when the entity rebinds.
+ publishIsBusy();
--- End diff --
I take it this relies on the atomic integer being persisted upon shutdown.
Say you have just invoked one effector - what would happen if the server were
shut down before the effector task had been invoked? In this case does the
task get cancelled? Upon rebind, would we get a non zero value on the counter,
but there would no longer be a task that would ever decrement it to zero?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
