Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-client/pull/30#discussion_r84979933
--- Diff: cli/commands/application.go ---
@@ -91,10 +87,16 @@ func (cmd *Application) show(appName string) {
}
table.Add("Type:", application.Spec.Type)
table.Add("CatalogItemId:", entity.CatalogItemId)
- table.Add("LocationId:", strings.Join(application.Spec.Locations, ", "))
- table.Add("LocationName:", location.Name)
- table.Add("LocationSpec:", location.Spec)
- table.Add("LocationType:", location.Type)
+ if len(application.Spec.Locations) > 0 {
--- End diff --
Agree it'd be nice but need to be careful with that.
In normal usage the first location is the one defined in YAML and a second
location if present usually would be an SshMachineLocation, created from the
first one. That's not user specified (and kind of internal detail) so better
not display it here.
On the other hand it's still possible to pass multiple locations from YAML.
Not sure what the use case would be here (availability zones?).
Merging the fix and can discuss how to best display multiple locations on
the mailing list.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
