Github user geomacy commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/392#discussion_r85079113
  
    --- Diff: 
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/BrooklynDslInterpreter.java
 ---
    @@ -147,7 +147,7 @@ public Object evaluate(Object f, boolean 
deepEvaluation) {
             }
     
             if (f instanceof QuotedString) {
    -            return ((QuotedString)f).unwrapped();
    +            return 
BrooklynDslCommon.template(((QuotedString)f).unwrapped());
    --- End diff --
    
    Does this turn *every* quoted string into a template? Is that perhaps too 
broad a change - maybe better to restrict to explicit `$brooklyn:template()` to 
avoid possibility of starting to interpret text as templates, perhaps in 
formatString expressions?   I dare say it's unlikely, but possible.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to