Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/412#discussion_r86834710
--- Diff:
core/src/test/java/org/apache/brooklyn/enricher/stock/EnrichersTest.java ---
@@ -201,17 +201,16 @@ public void
testTransformingRespectsUnchangedButWillRepublish() {
entity.sensors().set(STR1, "myval");
Asserts.eventually(Suppliers.ofInstance(record),
CollectionFunctionals.sizeEquals(1));
- EntityAsserts.assertAttributeEquals(entity, STR2, "myval");
+ EntityAsserts.assertAttributeEqualsEventually(entity, STR2,
"myval");
--- End diff --
This test still fails for me. When running on an overloaded machine (I was
compiling + running all the brooklyn-server tests concurrently!), it failed in
a couple of places:
* The first `Asserts.assertThat(record.getEvents(),
CollectionFunctionals.sizeEquals(0))` with the error
```
java.lang.AssertionError: Failed IsEqualTo(0)(sizeFunction):
[TestEntityImpl{id=wcvg8rr83b}.Sensor: test.str2 (java.lang.String)=null @
1478542432319]
```
* The final assertion `Asserts.eventually(Suppliers.ofInstance(record),
CollectionFunctionals.sizeEquals(5));` - it had 6 items; the error was:
```
java.lang.AssertionError: Expected: eventually IsEqualTo(5)(sizeFunction);
got most recently: RecordingSensorEventListener[size=6;
events=[TestEntityImpl{id=gybou1giff}.Sensor: test.str2 (java.lang.String)=null
@ 1478542608719, TestEntityImpl{id=gybou1giff}.Sensor: test.str2
(java.lang.String)=myval @ 1478542608725, TestEntityImpl{id=gybou1giff}.Sensor:
test.str2 (java.lang.String)=myval2 @ 1478542609735,
TestEntityImpl{id=gybou1giff}.Sensor: test.str2 (java.lang.String)=myval2 @
1478542609739, TestEntityImpl{id=gybou1giff}.Sensor: test.str2
(java.lang.String)=myval2 @ 1478542609741,
TestEntityImpl{id=gybou1giff}.Sensor: test.str2 (java.lang.String)=myval3 @
1478542609744]] (waited 1s 5ms 196us, checked 86)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
