Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/426#discussion_r87422520
--- Diff:
utils/common/src/test/java/org/apache/brooklyn/util/javalang/MemoryUsageTrackerTest.java
---
@@ -84,36 +89,82 @@ private long sizeOfActiveReferences(List<Maybe<byte[]>>
references) {
@Test(groups="Integration")
public void testSoftUsageAndClearance() {
- long totalMemory = Runtime.getRuntime().totalMemory();
- long freeMemory = Runtime.getRuntime().freeMemory();
+ MemoryUsageSummary initialMemory = new MemoryUsageSummary();
+ LOG.info("Memory usage at start of test: "+initialMemory);
+
+ MemoryUsageSummary beforeCollectedMemory = null;
List<Maybe<?>> dump = MutableList.of();
- Maybe<byte[]> first = Maybe.soft(new byte[1000*1000]);
- dump.add(first);
for (int i=0; i<1000*1000; i++) {
- totalMemory = Runtime.getRuntime().totalMemory();
- freeMemory = Runtime.getRuntime().freeMemory();
+ beforeCollectedMemory = new MemoryUsageSummary();
dump.add(Maybe.soft(new byte[1000*1000]));
- if (first.isAbsent()) break;
+ if (containsAbsent(dump)) break;
}
- int cleared = 0;
- for (Maybe<?> m: dump) { if (m.isAbsent()) cleared++; }
- LOG.info("First soft reference cleared after "+dump.size()+" 1M
blocks created; "+cleared+" of them cleared");
+ int cleared = countAbsents(dump);
+ LOG.info("First soft reference cleared after "+dump.size()+" 1M
blocks created; "+cleared+" of them cleared; memory just before collected is
"+beforeCollectedMemory);
--- End diff --
`assertTrue(cleared)`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
