Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/425#discussion_r87448337
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/JcloudsLocationSecurityGroupCustomizer.java
---
@@ -320,19 +319,22 @@ void
removePermissionsFromLocation(Iterable<IpPermission> permissions, final Str
* look for the uniqueSecurityGroup rather than the shared
securityGroup.
*
* @param nodeId The id of the node in question
- * @param locationId The id of the location in question
- * @param securityApi The API to use to list security groups
+ * @param groupEditor The id of the node in question
* @return the security group unique to the given node, or null if one
could not be determined.
*/
- private SecurityGroup
getUniqueSecurityGroupForNodeCachingSharedGroupIfPreviouslyUnknown(String
nodeId, String locationId, SecurityGroupExtension securityApi) {
- Set<SecurityGroup> groupsOnNode =
securityApi.listSecurityGroupsForNode(nodeId);
+ private SecurityGroup
getUniqueSecurityGroupForNodeCachingSharedGroupIfPreviouslyUnknown(String
nodeId,
+ final JcloudsLocationSecurityGroupEditor groupEditor) {
--- End diff --
Thank you for breaking those long signatures :)
If there was one styling change to force I'd choose a line length limit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
